Taragolis commented on code in PR #34807:
URL: https://github.com/apache/airflow/pull/34807#discussion_r1355852578
##########
airflow/providers/amazon/aws/waiters/databrew.json:
##########
@@ -0,0 +1,54 @@
+{
+ "version": 2,
+ "waiters": {
+ "job_complete": {
+ "operation": "DescribeJobRun",
+ "delay": 30,
+ "maxAttempts": 60,
+ "acceptors": [
+ {
+ "matcher": "path",
+ "argument": "State",
+ "expected": "STOPPED",
+ "state": "success"
+ },
+ {
+ "matcher": "path",
+ "argument": "State",
+ "expected": "SUCCEEDED",
+ "state": "success"
+ },
+ {
+ "matcher": "path",
+ "argument": "State",
+ "expected": "FAILED",
+ "state": "success"
+ },
+ {
+ "matcher": "path",
+ "argument": "State",
+ "expected": "TIMEOUT",
+ "state": "success"
+ },
+ {
+ "matcher": "path",
+ "argument": "State",
+ "expected": "Starting",
+ "state": "retry"
+ },
+ {
+ "matcher": "path",
+ "argument": "State",
+ "expected": "STOPPING",
+ "state": "retry"
+ },
+ {
+ "matcher": "path",
+ "argument": "State",
+ "expected": "RUNNING",
+ "state": "retry"
+ }
Review Comment:
Hmmm…. I was check internal botocore waiters and found that some waiters use
`retry` in case if matcher is an error
https://github.com/boto/botocore/blob/master/botocore/data/ec2/2016-11-15/waiters-2.json
##########
airflow/providers/amazon/aws/waiters/databrew.json:
##########
@@ -0,0 +1,54 @@
+{
+ "version": 2,
+ "waiters": {
+ "job_complete": {
+ "operation": "DescribeJobRun",
+ "delay": 30,
+ "maxAttempts": 60,
+ "acceptors": [
+ {
+ "matcher": "path",
+ "argument": "State",
+ "expected": "STOPPED",
+ "state": "success"
+ },
+ {
+ "matcher": "path",
+ "argument": "State",
+ "expected": "SUCCEEDED",
+ "state": "success"
+ },
+ {
+ "matcher": "path",
+ "argument": "State",
+ "expected": "FAILED",
+ "state": "success"
+ },
+ {
+ "matcher": "path",
+ "argument": "State",
+ "expected": "TIMEOUT",
+ "state": "success"
+ },
+ {
+ "matcher": "path",
+ "argument": "State",
+ "expected": "Starting",
+ "state": "retry"
+ },
+ {
+ "matcher": "path",
+ "argument": "State",
+ "expected": "STOPPING",
+ "state": "retry"
+ },
+ {
+ "matcher": "path",
+ "argument": "State",
+ "expected": "RUNNING",
+ "state": "retry"
+ }
Review Comment:
Hmmm…. I was check internal botocore waiters and found that some waiters use
`retry` in case if matcher is an error
https://github.com/boto/botocore/blob/master/botocore/data/ec2/2016-11-15/waiters-2.json
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@airflow.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
