eladkal commented on code in PR #34807:
URL: https://github.com/apache/airflow/pull/34807#discussion_r1356651111


##########
airflow/providers/amazon/aws/hooks/glue.py:
##########
@@ -422,3 +422,55 @@ def create_or_update_glue_job(self) -> str | None:
             self.conn.create_job(**config)
 
         return self.job_name
+
+
+class GlueDataBrewHook(AwsBaseHook):

Review Comment:
   There is a simple answer to where to put it.
   
   If I am a user of `databrew` what is the first place that I will look to 
find databrew related code? (This question is regardless of Airflow itself.. 
it's the same for doc search or any other thing related to the service)
   obviously I will go under `Amazon/aws` but what after?
   would it be under `glue`  / `databrew` / `glue_databrew` ?
   If most users are going naturally to A then code should be in A.
   This is the only question that matters.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@airflow.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Reply via email to