potiuk commented on code in PR #34247:
URL: https://github.com/apache/airflow/pull/34247#discussion_r1387343224


##########
.pre-commit-config.yaml:
##########
@@ -1030,3 +1030,12 @@ repos:
         files: 
^airflow/migrations/versions/.*\.py$|^docs/apache-airflow/migrations-ref\.rst$
         additional_dependencies: ['rich>=12.4.4']
         ## ONLY ADD PRE-COMMITS HERE THAT REQUIRE CI IMAGE
+      - id: bandit

Review Comment:
   And to add even more: system pre-commit are special - they will  **just** 
run whatever you put there as a script. This is how we are adding the 
pre-commits that are using `breeze` CI image to run stuff - those scripts of 
ours will make sure the image is locally built and they will run `docker run` 
to run whatever they need to run as part of the check. There the `environment` 
managerment responsibility is passed from pre-commit to breeze essentially.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@airflow.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Reply via email to