potiuk commented on code in PR #34247:
URL: https://github.com/apache/airflow/pull/34247#discussion_r1387342153
##########
.pre-commit-config.yaml:
##########
@@ -1030,3 +1030,12 @@ repos:
files:
^airflow/migrations/versions/.*\.py$|^docs/apache-airflow/migrations-ref\.rst$
additional_dependencies: ['rich>=12.4.4']
## ONLY ADD PRE-COMMITS HERE THAT REQUIRE CI IMAGE
+ - id: bandit
Review Comment:
So just to add - basically with pre-commit you have 20 or so pre-commit
venvs that are automatically updated and maintained by pre-commit (distinct set
of requirements). They have nothing to do with either `airflow` requirements
nor `breeze image` requirements :). It's just using (well) the approach that
for every tool (every check) you should have separate venv that you run it in.
And pre-commit does all the heavy lifting to:
a) maintain them (upgrade when you change the requirements
b) share them between checks if several checks use the same set of
requirements
c) make sure each check uses the right venv..
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@airflow.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
