potiuk commented on code in PR #34247:
URL: https://github.com/apache/airflow/pull/34247#discussion_r1387345625
##########
.pre-commit-config.yaml:
##########
@@ -1030,3 +1030,12 @@ repos:
files:
^airflow/migrations/versions/.*\.py$|^docs/apache-airflow/migrations-ref\.rst$
additional_dependencies: ['rich>=12.4.4']
## ONLY ADD PRE-COMMITS HERE THAT REQUIRE CI IMAGE
+ - id: bandit
Review Comment:
(or we rather used to do it) -> I recalled that I converted all such
"scripts" to python to make it easier. So those are now `python` ones with very
small set of requirements `['rich>=12.4.4', 'inputimeout', 'pyyaml']` for
examplte that run bootstrapping python script
(`./scripts/ci/pre_commit/pre_commit_mypy.py` for example), but essentially
what the script does is to run docker command:
```
cmd_result = run_command(
[
"docker",
"run",
"-t",
....
```
So the "bootstrapping script` uses the small ``['rich>=12.4.4',
'inputimeout', 'pyyaml']` venv - to launch docker command in airflow's CI
image....
##########
.pre-commit-config.yaml:
##########
@@ -1030,3 +1030,12 @@ repos:
files:
^airflow/migrations/versions/.*\.py$|^docs/apache-airflow/migrations-ref\.rst$
additional_dependencies: ['rich>=12.4.4']
## ONLY ADD PRE-COMMITS HERE THAT REQUIRE CI IMAGE
+ - id: bandit
Review Comment:
(or we rather used to do it) -> I recalled that I converted all such
"scripts" to python to make it easier. So those are now `python` ones with very
small set of requirements `['rich>=12.4.4', 'inputimeout', 'pyyaml']` for
examplte that run bootstrapping python script
(`./scripts/ci/pre_commit/pre_commit_mypy.py` for example), but essentially
what the script does is to run docker command:
```
cmd_result = run_command(
[
"docker",
"run",
"-t",
....
```
So the `bootstrapping script` uses the small ``['rich>=12.4.4',
'inputimeout', 'pyyaml']` venv - to launch docker command in airflow's CI
image....
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@airflow.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
