jscheffl commented on code in PR #36487: URL: https://github.com/apache/airflow/pull/36487#discussion_r1438431448
########## airflow/models/taskinstance.py: ########## @@ -3398,10 +3405,12 @@ def clear_db_references(self, session): for table in tables: session.execute( delete(table).where( - table.dag_id == self.dag_id, - table.task_id == self.task_id, - table.run_id == self.run_id, - table.map_index == self.map_index, + # Note: Need to add some type ignores, mypy does not understand that all tables Review Comment: Okay, added a second commit which adds a bit of re-factoring by introduction of a base class... don't know if this is better or making it worse... -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@airflow.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org