jscheffl commented on code in PR #36487:
URL: https://github.com/apache/airflow/pull/36487#discussion_r1438901189
##########
airflow/models/renderedtifields.py:
##########
@@ -49,7 +49,7 @@
from airflow.models.taskinstance import TaskInstance, TaskInstancePydantic
-class RenderedTaskInstanceFields(Base):
+class RenderedTaskInstanceFields(TaskInstanceDependencies):
Review Comment:
I tried to - and actually understood this is the core of class inheritance
in all common languages - but I was "surprised" - if not contained in base
class, the mypy check complained, if I left it out in all 5 inherited classes,
then it was not working "at all".
Maybe I am lagging some stars (****) in python understanding, if you have
more super power (***** in python) maybe you can enlighten me?
Can you try removing these lines, then it is miserably failing totally.
I don't know if this is pecific to SQLAlchemy, but somehow the defined
fields were not inherited.
##########
airflow/models/renderedtifields.py:
##########
@@ -49,7 +49,7 @@
from airflow.models.taskinstance import TaskInstance, TaskInstancePydantic
-class RenderedTaskInstanceFields(Base):
+class RenderedTaskInstanceFields(TaskInstanceDependencies):
Review Comment:
I tried to - and actually understood this is the core of class inheritance
in all common languages - but I was "surprised" - if not contained in base
class, the mypy check complained, if I left it out in all 5 inherited classes,
then it was not working "at all".
Maybe I am lagging some stars (****) in python understanding, if you have
more super power (***** in python) maybe you can enlighten me?
Can you try removing these lines, then it is miserably failing totally.
I don't know if this is specific to SQLAlchemy, but somehow the defined
fields were not inherited.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@airflow.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
