hussein-awala commented on code in PR #36487:
URL: https://github.com/apache/airflow/pull/36487#discussion_r1438901910


##########
airflow/models/renderedtifields.py:
##########
@@ -49,7 +49,7 @@
     from airflow.models.taskinstance import TaskInstance, TaskInstancePydantic
 
 
-class RenderedTaskInstanceFields(Base):
+class RenderedTaskInstanceFields(TaskInstanceDependencies):

Review Comment:
   I have no idea, but according to [the 
documentation](https://docs.sqlalchemy.org/en/20/orm/inheritance.html), it 
should work; I will try it when I have some free time.
   
   Anyway, even if it works, maybe we should do that in a separate PR because 
it's a bit far from the original scope of this PR



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@airflow.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Reply via email to