potiuk commented on code in PR #36660: URL: https://github.com/apache/airflow/pull/36660#discussion_r1445063015
########## airflow/providers/amazon/provider.yaml: ########## @@ -81,23 +81,14 @@ dependencies: - apache-airflow-providers-common-sql>=1.3.1 - apache-airflow-providers-http # We should update minimum version of boto3 and here regularly to avoid `pip` backtracking with the number - # of candidates to consider. We should also make sure that all the below related packages have also the - # same minimum version specified. Boto3 1.28.0 has been released on July 6 2023. We should also make sure we - # set it to the version that `aiobotocore` supports (see `aiobotocore` optional dependency at the end - # of this file). Currently we set aiobotocore as minimum 2.5.3 - as this is was the first version - # that supported boto3 1.28. - # NOTE!!! BEFORE botocore 1.33 BOTOCORE VERSIONS ARE SHIFTED BY 3 MINOR VERSIONS - # NOTE!!! Make sure to update _MIN_BOTO3_VERSION in setup.py when you update it here - - boto3>=1.28.0 - # NOTE!!! BEFORE botocore 1.33 version is always shifted by 3 MINOR VERSIONS from boto3, see: - # - https://github.com/boto/boto3/issues/2702 - # - https://github.com/boto/boto3/blob/a3e710df58676c2567b8023dbe09025ad5e0e50f/.changes/1.33.0.json#L13-L15 - - botocore>=1.31.0 + # of candidates to consider. Make sure to configure boto3 version here as well as in all the tools below + # in the `devel-dependencies` section to be the same minimum version. + - boto3>=1.33.0 + - botocore>=1.33.0 - inflection>=0.5.1 - # Allow a wider range of watchtower versions for flexibility among users - - watchtower>=2.0.1,<4 + - watchtower>=3.0.0,<4 Review Comment: Yeah. I've been hesitating about that one too (for same reasons). But: 1) it's already > 1 year old 2) watchtower 2 is > 2 years old 3) users will still be able to use the providers (incluiding the one being voted now) with watchtower 2 We can **just** drop the limitation bump for watchtower from that one if that's a **real** problem - but I would at least want to know if there is a good reason for people to stick to watchtower 2. Because we could also treat it as a way to **make** people upgrade to watchtower 3 eventually if they are doing it mostly due to laziness and have no good reason for it. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@airflow.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org