potiuk commented on code in PR #36660:
URL: https://github.com/apache/airflow/pull/36660#discussion_r1445084997


##########
airflow/providers/amazon/provider.yaml:
##########
@@ -81,23 +81,14 @@ dependencies:
   - apache-airflow-providers-common-sql>=1.3.1
   - apache-airflow-providers-http
   # We should update minimum version of boto3 and here regularly to avoid 
`pip` backtracking with the number
-  # of candidates to consider. We should also make sure that all the below 
related packages have also the
-  # same minimum version specified. Boto3 1.28.0 has been released on July 6 
2023. We should also make sure we
-  # set it to the version that `aiobotocore` supports (see `aiobotocore` 
optional dependency at the end
-  # of this file). Currently we set aiobotocore as minimum 2.5.3 - as this is 
was the first version
-  # that supported boto3 1.28.
-  # NOTE!!! BEFORE botocore 1.33 BOTOCORE VERSIONS ARE SHIFTED BY 3 MINOR 
VERSIONS
-  # NOTE!!! Make sure to update _MIN_BOTO3_VERSION in setup.py when you update 
it here
-  - boto3>=1.28.0
-  # NOTE!!! BEFORE botocore 1.33 version is always shifted by 3 MINOR VERSIONS 
from boto3, see:
-  # - https://github.com/boto/boto3/issues/2702
-  # - 
https://github.com/boto/boto3/blob/a3e710df58676c2567b8023dbe09025ad5e0e50f/.changes/1.33.0.json#L13-L15
-  - botocore>=1.31.0
+  # of candidates to consider. Make sure to configure boto3 version here as 
well as in all the tools below
+  # in the `devel-dependencies` section to be the same minimum version.
+  - boto3>=1.33.0
+  - botocore>=1.33.0
   - inflection>=0.5.1
-  # Allow a wider range of watchtower versions for flexibility among users
-  - watchtower>=2.0.1,<4
+  - watchtower>=3.0.0,<4

Review Comment:
   BTW. Woudl be great to have a reference to an issue (?) opened somewhere 
about it (maybe?) This way we can refer to it in the comment and not to repeat 
it next time, until it is solved.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@airflow.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Reply via email to