Dev-iL commented on code in PR #37545:
URL: https://github.com/apache/airflow/pull/37545#discussion_r1495291662
##########
airflow/settings.py:
##########
@@ -107,6 +107,8 @@
"shutdown": "blue",
}
+SQL_ALCHEMY_V1 = sqlalchemy_version.startswith("1")
Review Comment:
@uranusjr Thank you for the comment. This was also raised in one of the
other threads:
https://github.com/apache/airflow/pull/37545#discussion_r1494649517
I don't mind adding a check using `importlib` and `packaging`, but I think
it shouldn't go to the sqlalchemy util, since as mentioned, we have another
example of checking the dependency version similarly (pendulum). I say these
checks should go into a dedicated "dependency versions" (or somesuch) utility.
Thoughts?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@airflow.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
