Taragolis commented on code in PR #37545: URL: https://github.com/apache/airflow/pull/37545#discussion_r1494980560
########## airflow/settings.py: ########## @@ -27,7 +27,7 @@ from typing import TYPE_CHECKING, Any, Callable import pluggy -from sqlalchemy import create_engine, exc, text +from sqlalchemy import __version__ as sqlalchemy_version, create_engine, exc, text Review Comment: > I thought EAFP was the preferred way to write python code. Nothing wrong, did I tell that it wrong? In general everything depends on the situation, depend on the cases. There was more hacky case rather than check the version -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@airflow.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
