Taragolis commented on code in PR #37545: URL: https://github.com/apache/airflow/pull/37545#discussion_r1494959852
########## airflow/settings.py: ########## @@ -27,7 +27,7 @@ from typing import TYPE_CHECKING, Any, Callable import pluggy -from sqlalchemy import create_engine, exc, text +from sqlalchemy import __version__ as sqlalchemy_version, create_engine, exc, text Review Comment: > [Not only in tests](https://github.com/apache/airflow/blob/016892b7d6bc654ac3ff7e4f8f9f7231f835bed7/airflow/utils/timezone.py#L32). Oh... yeah... that reminds me that we decide to not to use try except. But most possible pendulum 2 would be dropped into the Airflow 2.9 or 2.10 > Importlib metadata was [added in py3.8,](https://docs.python.org/3/library/importlib.metadata.html) which is the minimum supported in airflow anyway, so no need to do any fancy checking. Importlib mandatory since 3.10, in cpython, I guess, most of the things implemented in 3.9. And something more, airflow read entire environment metadata during the providers loading, so this not a big deal even cache all packages installed into the environment. Anyway this one just a suggestion, no objections at this point. It could be changed in the future, we still not fully support SA2.0, so we have plenty a time. The point here, that some of package stop provide `__version__` (e.g. Flask and everything related to it) or newer provide it. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@airflow.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
