Re: [PR] Add DataToADLSOperator in Microsoft Azure provider [airflow]

Thu, 07 Mar 2024 00:45:10 -0800 


dabla commented on PR #37821:
URL: https://github.com/apache/airflow/pull/37821#issuecomment-1982974952

   > @dabla Let me clarify...
   > 
   > Your PR is requesting to merge changes on 6 files. One of them is: 
`tests/providers/microsoft/azure/transfers/test_local_to_adls.py`
   > 
   > <img alt="Screenshot 2024-03-07 at 10 01 16" width="324" 
src="https://private-user-images.githubusercontent.com/45845474/310795690-31526c24-35cf-4fd0-9ed6-b42e6c94553a.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3MDk4MDA3OTUsIm5iZiI6MTcwOTgwMDQ5NSwicGF0aCI6Ii80NTg0NTQ3NC8zMTA3OTU2OTAtMzE1MjZjMjQtMzVjZi00ZmQwLTllZDYtYjQyZTZjOTQ1NTNhLnBuZz9YLUFtei1BbGdvcml0aG09QVdTNC1ITUFDLVNIQTI1NiZYLUFtei1DcmVkZW50aWFsPUFLSUFWQ09EWUxTQTUzUFFLNFpBJTJGMjAyNDAzMDclMkZ1cy1lYXN0LTElMkZzMyUyRmF3czRfcmVxdWVzdCZYLUFtei1EYXRlPTIwMjQwMzA3VDA4MzQ1NVomWC1BbXotRXhwaXJlcz0zMDAmWC1BbXotU2lnbmF0dXJlPWMwYjcxMjc0YWNjNWNmMGE2NDgyYTk0Mjk3ZDA4YmZkZDE3MDEwMTI2NmVhMDIyYTk0MjRiN2U1MzNiZWViZWYmWC1BbXotU2lnbmVkSGVhZGVycz1ob3N0JmFjdG9yX2lkPTAma2V5X2lkPTAmcmVwb19pZD0wIn0.uUP8d_MKbJeT6IZPUOR5bs8MdpAHxRtkW2VIQ5ET3Mo";>
   > My point is that your PR should change only 5 files. There should be no 
changes on `tests/providers/microsoft/azure/transfers/test_local_to_adls.
   
   Ok now I understand what you mean, sorry for that, will remove this file 
from the pull request indeed it doesn't have to be there as nothing has to be 
changed there, this is l due to the refactoring I did.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@airflow.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Reply via email to