Re: [PR] Add `ADLSCreateObjectOperator` [airflow]

Thu, 07 Mar 2024 01:03:51 -0800 


dabla commented on PR #37821:
URL: https://github.com/apache/airflow/pull/37821#issuecomment-1983031334

   > @dabla Let me clarify...
   > 
   > Your PR is requesting to merge changes on 6 files. One of them is: 
`tests/providers/microsoft/azure/transfers/test_local_to_adls.py`
   > 
   > <img alt="Screenshot 2024-03-07 at 10 01 16" width="324" 
src="https://private-user-images.githubusercontent.com/45845474/310795690-31526c24-35cf-4fd0-9ed6-b42e6c94553a.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3MDk4MDEwOTksIm5iZiI6MTcwOTgwMDc5OSwicGF0aCI6Ii80NTg0NTQ3NC8zMTA3OTU2OTAtMzE1MjZjMjQtMzVjZi00ZmQwLTllZDYtYjQyZTZjOTQ1NTNhLnBuZz9YLUFtei1BbGdvcml0aG09QVdTNC1ITUFDLVNIQTI1NiZYLUFtei1DcmVkZW50aWFsPUFLSUFWQ09EWUxTQTUzUFFLNFpBJTJGMjAyNDAzMDclMkZ1cy1lYXN0LTElMkZzMyUyRmF3czRfcmVxdWVzdCZYLUFtei1EYXRlPTIwMjQwMzA3VDA4Mzk1OVomWC1BbXotRXhwaXJlcz0zMDAmWC1BbXotU2lnbmF0dXJlPTYwYTdjMDAzZGYyNjlkNDM5MmFlMGZkZjZjZjcyN2QzOWVlMDczZjAxMmQ2MWZmMzhlNDNkNmMyN2RiNzI5YjEmWC1BbXotU2lnbmVkSGVhZGVycz1ob3N0JmFjdG9yX2lkPTAma2V5X2lkPTAmcmVwb19pZD0wIn0.kYTjc3C6UrV1BKfV6TTtKAWcQ56_UiEbjnrekHP-E5U";>
   > My point is that your PR should change only 5 files. There should be no 
changes on `tests/providers/microsoft/azure/transfers/test_local_to_adls.py`
   
   Ok it's because the branch was based on the other PR with proxy fix where I 
had to the new operator, so it will be hard to remove that file.  What do you 
want me to do, create a new PR for this one based on main?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@airflow.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Reply via email to