Taragolis commented on code in PR #38178: URL: https://github.com/apache/airflow/pull/38178#discussion_r1526233196
########## tests/providers/amazon/aws/operators/test_ecs.py: ########## @@ -680,6 +681,23 @@ def test_execute_complete(self, client_mock): # task gets described to assert its success client_mock().describe_tasks.assert_called_once_with(cluster="c", tasks=["my_arn"]) + @pytest.mark.db_test + def test_partial_deprecated_region(self, dag_maker): + with dag_maker("test_partial_deprecated_region_esc_run_task"): + EcsRunTaskOperator.partial( + task_id="fake-task-id", + region="ca-west-1", + cluster="foo", + task_definition="bar", + ).expand(overrides=[{}, {}, {}]) + + dr = dag_maker.create_dagrun(execution_date=timezone.utcnow()) + warning_match = r"`region` is deprecated and will be removed" + for ti in dr.task_instances: + with pytest.warns(AirflowProviderDeprecationWarning, match=warning_match): + ti.render_templates() Review Comment: So I revert 32d0964 instead. I do not have an idea how to render templates for mapped TI without actually run it, in this case session should correctly closed. But for avoid regression better to run `full tests` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@airflow.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org