o-nikolas commented on code in PR #38178:
URL: https://github.com/apache/airflow/pull/38178#discussion_r1526688147
##########
tests/providers/amazon/aws/operators/test_base_aws.py:
##########
@@ -171,3 +177,40 @@ class SoWrongOperator(AwsBaseOperator):
error_match = r"Class attribute 'SoWrongOperator.aws_hook_class' is
not a subclass of AwsGenericHook"
with pytest.raises(AttributeError, match=error_match):
SoWrongOperator(task_id="fake-task-id")
+
+ @pytest.mark.parametrize(
+ "region, region_name, expected_region_name",
+ [
+ pytest.param("ca-west-1", None, "ca-west-1", id="region-only"),
+ pytest.param("us-west-1", "us-west-1", "us-west-1",
id="non-ambiguous-params"),
Review Comment:
What would happen for a test case where both are provided but different?
Would `region_name` win-out in if partial is being used and `region` otherwise?
You might want to add a check in src to ensure they're the same if so.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@airflow.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
