vincbeck commented on code in PR #38178:
URL: https://github.com/apache/airflow/pull/38178#discussion_r1526333491
##########
airflow/providers/amazon/aws/operators/base_aws.py:
##########
@@ -85,10 +86,12 @@ def __init__(
region_name: str | None = None,
verify: bool | str | None = None,
botocore_config: dict | None = None,
+ region: str | None | ArgNotSet = NOTSET, # Required for `.partial`
signature check
**kwargs,
):
+ additional_params = {} if region is NOTSET else {"region": region}
hook_params = AwsHookParams.from_constructor(
- aws_conn_id, region_name, verify, botocore_config,
additional_params=kwargs
+ aws_conn_id, region_name, verify, botocore_config,
additional_params=additional_params
Review Comment:
Is not it a breaking change? `kwargs` is no longer passed to
`from_constructor`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@airflow.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
