chz8494 commented on PR #38614: URL: https://github.com/apache/airflow/pull/38614#issuecomment-2029906734
> The verify argument is present in [Airflow documentation ](https://github.com/apache/airflow/blob/8b723e498de47a14f4d2dc13d5a2b876d42d7ff8/docs/apache-airflow-providers-hashicorp/secrets-backends/hashicorp-vault.rst#vault-running-with-self-signed-certificates), but looks like it was accidentally removed by a change, so we need to add a test to avoid removing your fix in the future; could you add the test? https://github.com/apache/airflow/blob/3568b09e8c7501bd84d08d594038dea9b8e20a23/tests/providers/hashicorp/_internal_client/test_vault_client.py https://github.com/apache/airflow/blob/d3dc88f0844bcb377a9e52312e1a99b5ca6e617e/tests/providers/hashicorp/_internal_client/test_vault_client.py#L615 I'd like to help but don't understand how to run this test, seems it needs to be used against local vault server localhost:8081? but I don't know how it can be used on git-ci... In addition, I traced back up to 2.1.0 but couldn't find any code related to `verify`, I'd assume this `session` change was new in recent kv_client update and `verify` logic in provider was never in place, someone coded it and expected **kwargs could automatically cover `verify` key value, which it's not happening. see kv client doc and code: https://github.com/hvac/hvac/blob/48027db42c037fe8f6b1c6fd8f6dbf80c1ea8595/docs/advanced_usage.rst#L108 https://github.com/hvac/hvac/blob/48027db42c037fe8f6b1c6fd8f6dbf80c1ea8595/hvac/adapters.py#L90 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@airflow.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
