hussein-awala commented on PR #38614: URL: https://github.com/apache/airflow/pull/38614#issuecomment-2029919432
> I'd like to help but don't understand how to run this test, seems it needs to be used against local vault server localhost:8081? They are unit tests and not integration tests, so we use Python mock package to patch the methods/classes. You can check [the testing docs](https://github.com/apache/airflow/blob/main/contributing-docs/09_testing.rst) in [the contributing documentation](https://github.com/apache/airflow/blob/main/contributing-docs). > In addition, I traced back up to 2.1.0 but couldn't find any code related to verify, I'd assume this session change was new in recent kv_client update and verify logic in provider was never in place, someone coded it and expected **kwargs could automatically cover verify key value, which it's not happening. This is possible, but we need to add tests to avoid breaking the fix in the future. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@airflow.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
