potiuk commented on code in PR #39513: URL: https://github.com/apache/airflow/pull/39513#discussion_r1598138877
########## tests/providers/openlineage/plugins/test_listener.py: ########## @@ -33,10 +33,20 @@ from airflow.providers.openlineage.plugins.listener import OpenLineageListener from airflow.providers.openlineage.utils.selective_enable import disable_lineage, enable_lineage from airflow.utils.state import State +from tests.test_utils.compat import AIRFLOW_V_2_10_PLUS from tests.test_utils.config import conf_vars pytestmark = pytest.mark.db_test +EXPECTED_TRY_NUMBER_1 = 1 if AIRFLOW_V_2_10_PLUS else 0 Review Comment: Yes. I think "old OL provider" + "Airlfow 2.9" work fine. New OL provider + Airflow 2.10 as well. What is problematic is what happens when we mix them. > We should maybe provide a max Airflow version for previous releases of OL provider. This is not possible. Release is immutable once released. > or a min provider version for Airflow version starting 2.10 (or 2.9.2 if cherry picked). We are not going to cherry-pick that change, I think - seeing how it interacts with OL (@dstandish ?) . We cannot really have mininimum version specified in dependencies in a "hard" way (optional dependencies like `openlineage` extra can have limits but they are not enforced, they are only used at installation time temporarily and only if someone actually uses the extra directly - `apache-airlfow[openlineage]` - so for example when you install directly `apache-airflow-providers-openlineage` `apache-airlfow` together, the limits in `openlineage` extra are not used) . Those checks will have to be done at runtime. I think what we will have to do is to: 1) have runtime check in airflow to see if openlineage is installed and if so, check it's version is > 1.8.0 2) in openlinage provider have compatibility code to check if airflow version is < 2.10 and apply the old try_num adjustments in this case -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@airflow.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
