vincbeck commented on code in PR #39608:
URL: https://github.com/apache/airflow/pull/39608#discussion_r1600558492


##########
airflow/providers/amazon/aws/operators/batch.py:
##########
@@ -206,8 +206,8 @@ def __init__(
         self.scheduling_priority_override = scheduling_priority_override
         self.array_properties = array_properties
         self.parameters = parameters or {}
-        self.retry_strategy = retry_strategy or {}
-        if not self.retry_strategy.get("attempts", None):
+        self.retry_strategy = retry_strategy
+        if self.retry_strategy is not None and not 
self.retry_strategy.get("attempts", None):

Review Comment:
   It is breaking change but we should treat it as bug fix since the current 
behavior does not make sense



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@airflow.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Reply via email to