o-nikolas commented on code in PR #39608: URL: https://github.com/apache/airflow/pull/39608#discussion_r1600773364
########## airflow/providers/amazon/aws/operators/batch.py: ########## @@ -206,8 +206,8 @@ def __init__( self.scheduling_priority_override = scheduling_priority_override self.array_properties = array_properties self.parameters = parameters or {} - self.retry_strategy = retry_strategy or {} - if not self.retry_strategy.get("attempts", None): + self.retry_strategy = retry_strategy + if self.retry_strategy is not None and not self.retry_strategy.get("attempts", None): Review Comment: I think just as many people may have been benefiting and enjoying the last defaulting implementation (adding the attempts), I don't see that as so clearly wrong here. The whole point of Airflow operators is to make it easy and convenient for users to build workflows without needing to know the minutiae of the underlying SDK, otherwise everyone would just use taskflow/python operator with the boto sdk directly. We default values on behalf of the user very frequently. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@airflow.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org