o-nikolas commented on code in PR #39608: URL: https://github.com/apache/airflow/pull/39608#discussion_r1602112239
########## airflow/providers/amazon/aws/operators/batch.py: ########## @@ -206,8 +206,8 @@ def __init__( self.scheduling_priority_override = scheduling_priority_override self.array_properties = array_properties self.parameters = parameters or {} - self.retry_strategy = retry_strategy or {} - if not self.retry_strategy.get("attempts", None): + self.retry_strategy = retry_strategy + if self.retry_strategy is not None and not self.retry_strategy.get("attempts", None): Review Comment: > The retry strategy specified in the job definition is either specified by the user, or if the user doesn't specify one, it will have one attempt. See "By default, each job is given one attempt to move to either the SUCCEEDED or FAILED job state" [here](https://docs.aws.amazon.com/batch/latest/userguide/job_retries.html) This is a completely different story then, if the new default with no input provided still matches the previous default we had then we have no issue and I see no back-compat issues and the discussion is moot. @vincbeck @ferruzzi agreed? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@airflow.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org