ferruzzi commented on code in PR #39908:
URL: https://github.com/apache/airflow/pull/39908#discussion_r1670979166
##########
tests/_internals/forbidden_warnings.py:
##########
@@ -62,6 +62,11 @@ def pytest_itemcollected(self, item: pytest.Item):
# Add marker at the beginning of the markers list. In this case,
it does not conflict with
# filterwarnings markers, which are set explicitly in the test
suite.
item.add_marker(pytest.mark.filterwarnings(f"error::{fw}"),
append=False)
+ item.add_marker(
Review Comment:
As I said on Slack, I don't see anything that changes my previous comment
from last month.
> To add to that, even if we do standardize them, why break two (Datadog and
Otel) to match one (StatsD)? If we were going to do this, shouldn't we change
the one that doesn't match the other two?
We get YACO (yet another config option) but we're still breaking two
backends. Without some usage numbers to see what percentage of users are
going to be affected here, I don't agree with this.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@airflow.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
