dirrao commented on code in PR #39908:
URL: https://github.com/apache/airflow/pull/39908#discussion_r1692852416
##########
tests/_internals/forbidden_warnings.py:
##########
@@ -62,6 +62,11 @@ def pytest_itemcollected(self, item: pytest.Item):
# Add marker at the beginning of the markers list. In this case,
it does not conflict with
# filterwarnings markers, which are set explicitly in the test
suite.
item.add_marker(pytest.mark.filterwarnings(f"error::{fw}"),
append=False)
+ item.add_marker(
Review Comment:
@potiuk / @kaxil
I am still confused about the final timer metric unit for unification. is it
milli seconds or seconds? Can you please clarify it?
@ferruzzi recommends going with seconds instead of milliseconds in the
earlier conversation. I am biased towards milliseconds. However, I am good with
seconds as well.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@airflow.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
