potiuk commented on code in PR #39908:
URL: https://github.com/apache/airflow/pull/39908#discussion_r1681282210
##########
tests/_internals/forbidden_warnings.py:
##########
@@ -62,6 +62,11 @@ def pytest_itemcollected(self, item: pytest.Item):
# Add marker at the beginning of the markers list. In this case,
it does not conflict with
# filterwarnings markers, which are set explicitly in the test
suite.
item.add_marker(pytest.mark.filterwarnings(f"error::{fw}"),
append=False)
+ item.add_marker(
Review Comment:
I'd say - it's "right" to do, but I 'd also say - since we have Airflow 3
coming, this could be another breaking change that could be done as part of
Airflow 3 implementation without adding config option. And should be
accompanied with explanation on what the users should do in their metrics and
dashboards - basically migration notes explaining what is going to change.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@airflow.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
