shahar1 commented on PR #44486:
URL: https://github.com/apache/airflow/pull/44486#issuecomment-2508235669

   > As part of this task, #44436 mentions as well "re-join back methods that 
were separated out from the main code - when methods start with _". Are you 
planning to do it in this PR? I'd advice to either do it as part of this PR or 
do the re-join before removing the decorator. Once the decorator is removed, it 
will be harder to look for methods that were used to be used for AIP-44 and 
needs to be re-joined
   
   Yes, that's why I just drafted it :)
   I'll take care of it, but just to make sure that I understand "re-join" 
correctly - everywhere where there's both `def fun()` and `def _fun()`, simply 
restore the logic from `_fun()` to `fun()`, or is it deeper than that? (it's my 
first time in the API area)


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@airflow.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Reply via email to