shahar1 commented on PR #44486:
URL: https://github.com/apache/airflow/pull/44486#issuecomment-2508295954

   > > Yes, that's why I just drafted it :)
   > 
   > Cool :)
   > 
   > > I'll take care of it, but just to make sure that I understand "re-join" 
correctly - everywhere where there's both def fun() and def _fun(), simply 
restore the logic from _fun() to fun(), or is it deeper than that?
   > 
   > Yes you understood well what re-join means. When working on AIP-44, many 
methods were moved to private functions to make them "callable". You'll see 
many methods like:
   > 
   > ```
   > @classmethod
   > @internal_api_call
   > def function_name(self, ...)
   >   return _function_name(...)
   > ```
   > 
   > The goal is to move back the implementation of `_function_name` into 
`function_name`.
   > 
   > > Also, what should I do if _fun() is called more than once like 
./airflow/dag_processing/processor.py: _execute_task_callbacks? (it's my first 
time in the API area)
   > 
   > In this case, (please @potiuk correct me if I am wrong) I dont think we 
should re-join this method. `_execute_task_callbacks` is called in different 
methods and the separation makes sense.
   > 
   > > What should we do about these functions in rcp_api.py? Rename them to 
their original?
   > > Are you talking about 
`airflow/api_internal/endpoints/rpc_api_endpoint.py`? This file has been 
removed recently, so no need to take care of it
   > 
   > > It's my first time in the API area, so I'll try not to break too many 
things :)
   > 
   > No worries! Thanks for doing it! We all have to start someday right?
   
   I'm talking about `providers/src/airflow/providers/edge/worker_api/routes` 
(maybe @jscheffl could help with this one :) )


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@airflow.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Reply via email to