potiuk commented on code in PR #44718: URL: https://github.com/apache/airflow/pull/44718#discussion_r1881028446
########## providers/src/airflow/providers/jdbc/hooks/jdbc.py: ########## @@ -25,6 +25,7 @@ import jaydebeapi import jpype from sqlalchemy.engine import URL +from wrapt import synchronized Review Comment: I have not found "synchronized" as something that wrapt would publish as an interface. It seems it is somewhat accidentally available in wrapt implementation and might change any time. I think we should find a more "official" tool to doing it. ########## providers/src/airflow/providers/jdbc/hooks/jdbc.py: ########## @@ -25,6 +25,7 @@ import jaydebeapi import jpype from sqlalchemy.engine import URL +from wrapt import synchronized Review Comment: I have not found "synchronized" as something that wrapt would publish as an interface. It seems it is somewhat accidentally available in wrapt implementation and might change any time. I think we should find a more "official" tool to do it. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@airflow.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
