dabla commented on code in PR #44718: URL: https://github.com/apache/airflow/pull/44718#discussion_r1881605066
########## providers/src/airflow/providers/jdbc/hooks/jdbc.py: ########## @@ -25,6 +25,7 @@ import jaydebeapi import jpype from sqlalchemy.engine import URL +from wrapt import synchronized Review Comment: > Hmm. I found it in https://wrapt.readthedocs.io/en/master/examples.html - but search did not found it. It's therefore an example in wrapt - which is also a bit strange to rely on ? I liked the solution as to me, coming from Java, it seemed like a nice and clean solution. You can use the decorator as an aspect which prevents other threads from entering until the current one has finished, no need to hard code this into the function as this is a crosscutting concern, imho. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@airflow.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org