potiuk commented on code in PR #44718:
URL: https://github.com/apache/airflow/pull/44718#discussion_r1881040174


##########
providers/src/airflow/providers/jdbc/hooks/jdbc.py:
##########
@@ -25,6 +25,7 @@
 import jaydebeapi
 import jpype
 from sqlalchemy.engine import URL
+from wrapt import synchronized

Review Comment:
   Possibly better to use with 
   
   ```
   self.lock = threading.RLock()
   
   with self.lock:
        jaydebeapi.connect( ...
   ```
   
   It's essentially the same but better expresses the fact that we want to 
synchronize jaydebeapi, not the `get_conn` method.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@airflow.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Reply via email to