kaxil commented on code in PR #45043:
URL: https://github.com/apache/airflow/pull/45043#discussion_r1890584529


##########
task_sdk/tests/execution_time/test_supervisor.py:
##########
@@ -764,7 +764,7 @@ def watched_subprocess(self, mocker):
         [
             pytest.param(
                 GetConnection(conn_id="test_conn"),
-                b'{"conn_id":"test_conn","conn_type":"mysql"}\n',
+                
b'{"conn_id":"test_conn","conn_type":"mysql","type":"ConnectionResult"}\n',

Review Comment:
   >Why, what changed here for us having to do that?
   
   https://github.com/apache/airflow/pull/45043#discussion_r1890524124
   
   It was wrong from the start :) -- We weren't using or sending messages from 
Supervisor to the Task Runner. We were only checking if Supervisor can handle 
"that request".



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to