kaxil commented on code in PR #45043: URL: https://github.com/apache/airflow/pull/45043#discussion_r1890599962
########## task_sdk/src/airflow/sdk/execution_time/context.py: ########## @@ -0,0 +1,70 @@ +# Licensed to the Apache Software Foundation (ASF) under one +# or more contributor license agreements. See the NOTICE file +# distributed with this work for additional information +# regarding copyright ownership. The ASF licenses this file +# to you under the Apache License, Version 2.0 (the +# "License"); you may not use this file except in compliance +# with the License. You may obtain a copy of the License at +# +# http://www.apache.org/licenses/LICENSE-2.0 +# +# Unless required by applicable law or agreed to in writing, +# software distributed under the License is distributed on an +# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY +# KIND, either express or implied. See the License for the +# specific language governing permissions and limitations +# under the License. +from __future__ import annotations + +from typing import TYPE_CHECKING, Any + +import structlog + +if TYPE_CHECKING: + from airflow.sdk.execution_time.comms import ConnectionResult + + +def _convert_connection_result_conn(conn_result: ConnectionResult): + from airflow.sdk.definitions.connection import Connection + + return Connection(**conn_result.model_dump(exclude={"type"}, by_alias=True)) + + +def get_connection(conn_id: str): + # TODO: This should probably be moved to a separate module like `airflow.sdk.execution_time.comms` + # or `airflow.sdk.execution_time.connection` + # A reason to not move it to `airflow.sdk.execution_time.comms` is that it + # will make that module depend on Task SDK, which is not ideal because we intend to + # keep Task SDK as a separate package than execution time mods. + from airflow.sdk.execution_time.comms import GetConnection + from airflow.sdk.execution_time.task_runner import SUPERVISOR_COMMS + + log = structlog.get_logger(logger_name="task") + SUPERVISOR_COMMS.send_request(log=log, msg=GetConnection(conn_id=conn_id)) + msg = SUPERVISOR_COMMS.get_message() + return _convert_connection_result_conn(msg) + + +class ConnectionAccessor: + """Wrapper to access Connection entries in template.""" + + def __init__(self) -> None: + self.var: Any = None + + def __getattr__(self, key: str) -> Any: + self.var = get_connection(key) + return self.var + + def __repr__(self) -> str: + return str(self.var) + + def __eq__(self, other): + return self.var == other + + def get(self, key: str, default_conn: Any = None) -> Any: Review Comment: check https://github.com/apache/airflow/pull/45043#discussion_r1890599605 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
