kaxil commented on code in PR #45043:
URL: https://github.com/apache/airflow/pull/45043#discussion_r1890592354
##########
task_sdk/src/airflow/sdk/execution_time/comms.py:
##########
@@ -85,6 +85,13 @@ class XComResult(XComResponse):
class ConnectionResult(ConnectionResponse):
type: Literal["ConnectionResult"] = "ConnectionResult"
+ @classmethod
+ def from_conn_response(cls, connection_response: ConnectionResponse) ->
ConnectionResult:
Review Comment:
Wouldn't `response` be even more confusing :D ?
I can change it to `from_connection_response` if that feels more clearer --
but `response` alone is too confusing. `ConnectionResult.response` doesn't mean
much
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
