pierrejeambrun commented on code in PR #45062:
URL: https://github.com/apache/airflow/pull/45062#discussion_r1904238966
##########
airflow/models/backfill.py:
##########
@@ -316,21 +396,15 @@ def _create_backfill(
)
if not dag_model:
raise RuntimeError(f"Dag {dag_id} not found")
- for info in dagrun_info_list:
- backfill_sort_ordinal += 1
- _create_backfill_dag_run(
- dag=dag,
- info=info,
- backfill_id=br.id,
- dag_run_conf=br.dag_run_conf,
- reprocess_behavior=br.reprocess_behavior,
- backfill_sort_ordinal=backfill_sort_ordinal,
- session=session,
- )
- log.info(
- "created backfill dag run dag_id=%s backfill_id=%s, info=%s",
- dag.dag_id,
- br.id,
- info,
- )
- return br
+
+ backfill_response = _create_backfill_dag_run(
Review Comment:
`backfill_response` that variable name is not great. This makes me think of
an `http` response.
maybe `logical_dates` is more natural ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
