dstandish commented on code in PR #45062: URL: https://github.com/apache/airflow/pull/45062#discussion_r1904480168
########## airflow/models/backfill.py: ########## @@ -158,72 +151,125 @@ def validate_sort_ordinal(self, key, val): def _create_backfill_dag_run( Review Comment: Can you not make changes to this function but just keep it simple and essentially do the following: Do just like done for CLI, i.e. in `_do_dry_run`, but add the extra step of checking whether it would actually create the run? I.e. extra logic check for existence? We can use the same function for both cli and api. essentially, we just need to return the list "these rows would be created". I don't think we need to modify the path where we actually create the runs at this time. Let me know what you think of that. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
