prabhusneha commented on code in PR #45062:
URL: https://github.com/apache/airflow/pull/45062#discussion_r1905970788
##########
airflow/models/backfill.py:
##########
@@ -158,72 +151,125 @@ def validate_sort_ordinal(self, key, val):
def _create_backfill_dag_run(
*,
dag,
- info,
- reprocess_behavior: ReprocessBehavior,
+ dagrun_info_list,
+ reprocess_behavior: ReprocessBehavior | None = None,
backfill_id,
- dag_run_conf,
- backfill_sort_ordinal,
+ dag_run_conf: dict | None,
session,
-):
+ dry_run,
+) -> list[datetime]:
from airflow.models import DagRun
- with session.begin_nested() as nested:
- dr = session.scalar(
- with_row_locks(
- select(DagRun)
- .where(DagRun.logical_date == info.logical_date)
- .order_by(nulls_first(desc(DagRun.start_date),
session=session))
- .limit(1),
- session=session,
+ backfill_sort_ordinal = 0
+ logical_dates = []
+ dagrun_infos = list(dagrun_info_list)
Review Comment:
Currently `_get_info_list` returns Iterable[DagRunInfo]. Are you suggesting
changing it to list instead of Iterable?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
