pierrejeambrun commented on code in PR #45062: URL: https://github.com/apache/airflow/pull/45062#discussion_r1907162735
########## airflow/models/backfill.py: ########## @@ -158,72 +151,125 @@ def validate_sort_ordinal(self, key, val): def _create_backfill_dag_run( Review Comment: We are really close to it if I understand correctly. Daniel suggestion will clearly split code path for `dry_run` vs `non_dry_run` instead of having both intertwined which I think is better. `_create_backfill` signature is not correct. Then we don't modify the `_create_backfill_dag_run` but we just need to extract the `dry_run` logic inside its specific function `_do_dry_run`. I think it will be cleaner. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
