ashb commented on code in PR #45537:
URL: https://github.com/apache/airflow/pull/45537#discussion_r1910168707
##########
airflow/dag_processing/manager.py:
##########
@@ -923,9 +927,15 @@ def _create_process(self, dag_file: DagFileInfo) ->
DagFileProcessorProcess:
return DagFileProcessorProcess.start(
id=id,
- path=dag_file.path,
- callbacks=callback_to_execute_for_file,
- selector=self.selector,
+ client=None,
+ constructor_kwargs=dict(
+ selector=self.selector,
+ ),
+ target=_parse_file_entrypoint,
Review Comment:
Both subclasses accept target -- do we need to pull this out here? It feels
"leaky" to have a subclass but always have to pass the same value to it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]