ashb commented on code in PR #45537:
URL: https://github.com/apache/airflow/pull/45537#discussion_r1910171891


##########
task_sdk/src/airflow/sdk/execution_time/supervisor.py:
##########
@@ -423,12 +427,16 @@ def _close_unused_sockets(*sockets):
         for sock in sockets:
             sock.close()
 
-    def _on_child_started(self, ti: TaskInstance, path: str | 
os.PathLike[str], requests_fd: int):
+    def _on_child_started(self, *, requests_fd: int, **kwargs):
         """Send startup message to the subprocess."""
+        ti: TaskInstance = kwargs["ti"]
+        path: str | os.PathLike[str] = kwargs["path"]

Review Comment:
   Do we need to do this change? Other than mypy thinking that subclasses have 
to have the same signature, isn't this functionally identical? 



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to