jscheffl commented on PR #45270: URL: https://github.com/apache/airflow/pull/45270#issuecomment-2591265505
> Sorry this took me a bit to review. > > Now I see how sections work with the accordions so ignore my previous comment. > > It is a bit of a nitpick, but coudl we rename the field components? Along the lines of `NumberInput` instead of `FieldNumber`? > > I'm excited we're finally able to migrate all of this to react! Great work! Uff, this was a very good review! Learned something new. I assume now it needs a second iteration review from the rework... Had some challenges with the `flex-basis` - which is much cleaner in your proposal... but somehow not working. Any idea why? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@airflow.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
