jscheffl commented on code in PR #45270: URL: https://github.com/apache/airflow/pull/45270#discussion_r1917452245
########## airflow/ui/src/components/FlexibleForm/FieldDateTime.tsx: ########## @@ -0,0 +1,42 @@ +/*! + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ +import { Input } from "@chakra-ui/react"; + +import type { FlexibleFormElementProps } from "."; + +export type DateTimeElementProps = { + readonly subType: string; +} & FlexibleFormElementProps; + +const typeToPlaceholder: Record<string, string> = { + date: "yyyy-mm-dd", + "datetime-local": "yyyy-mm-ddThh:mm", + time: "hh:mm", +}; + +export const FieldDateTime = ({ name, param, subType }: DateTimeElementProps) => ( Review Comment: Nope, the placeholders are hard-coded. Do you know any chakra localizable option? I just checked but also using @orange_digital/chakra-datepicker is not a better option in my view... short research tells me... or I am blind - don't see better components available? Maybe we start the the US placeholders and rework later? Otherwise ideas welcome. (not an expert in this :-( are there localization libs?) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@airflow.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
