bbovenzi commented on code in PR #45270: URL: https://github.com/apache/airflow/pull/45270#discussion_r1915883268
########## airflow/ui/src/components/FlexibleForm/FieldSelector.tsx: ########## @@ -0,0 +1,118 @@ +/*! + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ +import type { ParamSchema, ParamSpec } from "src/queries/useDagParams"; + +import type { FlexibleFormElementProps } from "."; +import { FieldAdvancedArray } from "./FieldAdvancedArray"; +import { FieldBool } from "./FieldBool"; +import { FieldDateTime } from "./FieldDateTime"; +import { FieldDropdown } from "./FieldDropdown"; +import { FieldMultiSelect } from "./FieldMultiSelect"; +import { FieldMultilineText } from "./FieldMultilineText"; +import { FieldNumber } from "./FieldNumber"; +import { FieldObject } from "./FieldObject"; +import { FieldString } from "./FieldString"; +import { FieldStringArray } from "./FieldStringArray"; + +const inferType = (param: ParamSpec) => { + if (Boolean(param.schema.type)) { + // If there are multiple types, we assume that the first one is the correct one that is not "null". + // "null" is only used to signal the value is optional. + if (Array.isArray(param.schema.type)) { + return param.schema.type.find((type) => type !== "null") ?? "string"; + } + + return param.schema.type ?? "string"; + } + + // If the type is not defined, we infer it from the value. + if (Array.isArray(param.value)) { + return "array"; + } + + return typeof param.value; +}; + +const isFieldAdvancedArray = (fieldType: string, fieldSchema: ParamSchema) => + fieldType === "array" && fieldSchema.items?.type !== "string"; + +const isFieldBool = (fieldType: string) => fieldType === "boolean"; + +const isFieldDate = (fieldType: string, fieldSchema: ParamSchema) => + fieldType === "string" && fieldSchema.format === "date"; + +const isFieldDateTime = (fieldType: string, fieldSchema: ParamSchema) => + fieldType === "string" && fieldSchema.format === "date-time"; + +const enumTypes = ["string", "number", "integer"]; + +const isFieldDropdown = (fieldType: string, fieldSchema: ParamSchema) => + enumTypes.includes(fieldType) && Array.isArray(fieldSchema.enum); + +const isFieldMultilineText = (fieldType: string, fieldSchema: ParamSchema) => + fieldType === "string" && fieldSchema.format === "multiline"; + +const isFieldMultiSelect = (fieldType: string, fieldSchema: ParamSchema) => + fieldType === "array" && Array.isArray(fieldSchema.examples); + +const isFieldNumber = (fieldType: string) => { + const numberTypes = ["integer", "number"]; + + return numberTypes.includes(fieldType); +}; + +const isFieldObject = (fieldType: string) => fieldType === "object"; + +const isFieldStringArray = (fieldType: string, fieldSchema: ParamSchema) => + fieldType === "array" && + (!fieldSchema.items || fieldSchema.items.type === undefined || fieldSchema.items.type === "string"); + +const isFieldTime = (fieldType: string, fieldSchema: ParamSchema) => + fieldType === "string" && fieldSchema.format === "date"; Review Comment: ```suggestion fieldType === "string" && fieldSchema.format === "time"; ``` ########## airflow/ui/src/components/FlexibleForm/FieldDateTime.tsx: ########## @@ -0,0 +1,42 @@ +/*! + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ +import { Input } from "@chakra-ui/react"; + +import type { FlexibleFormElementProps } from "."; + +export type DateTimeElementProps = { + readonly subType: string; +} & FlexibleFormElementProps; + +const typeToPlaceholder: Record<string, string> = { + date: "yyyy-mm-dd", + "datetime-local": "yyyy-mm-ddThh:mm", + time: "hh:mm", +}; + +export const FieldDateTime = ({ name, param, subType }: DateTimeElementProps) => ( Review Comment: ```suggestion export const FieldDateTime = ({ name, param, ...rest }: FlexibleFormElementProps & InputProps) => ( ``` we can just use the existing InputProps. And the pre-existing placeholders are actually fine: <img width="843" alt="Screenshot 2025-01-14 at 10 03 21 PM" src="https://github.com/user-attachments/assets/946f46df-a415-4496-95d7-5cab138705c7"; /> -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@airflow.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
