potiuk commented on PR #45704: URL: https://github.com/apache/airflow/pull/45704#issuecomment-2595129236
> > get_connection isn't used/called for the BedrockAgentHook in example_bedrock_retrieve_and_generate.py (nor in any of the AwsHooks either) so I don't think this test is enough as it stands > > Yes. It was not called when aws_hook_conn_id was None - it fall-back to "default" retrieval (i.e. from AWS env vars or workload identity). But if you leave conn_id as default, it will try to get connection first This is actually what I found out while testing it. I reverted https://github.com/apache/airflow/pull/45690 and indeed get_connection was not called - not until I removed "aws_conn_id=None" in the original code. But it was called after I removed it and the test nicely failed as expected. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@airflow.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org