potiuk commented on code in PR #45704:
URL: https://github.com/apache/airflow/pull/45704#discussion_r1918206454
##########
providers/tests/system/amazon/aws/example_bedrock_retrieve_and_generate.py:
##########
@@ -442,9 +442,8 @@ def delete_opensearch_policies(collection_name: str):
test_context = sys_test_context_task()
env_id = test_context["ENV_ID"]
- aoss_client = OpenSearchServerlessHook(aws_conn_id=None)
- bedrock_agent_client = BedrockAgentHook(aws_conn_id=None)
-
+ aoss_client = OpenSearchServerlessHook()
+ bedrock_agent_client = BedrockAgentHook()
Review Comment:
BTW. IMHO this is actually the "correct" way of writing
"example_dags/system_tests" - it should rely on whatever user has as a
connection defined in their test environment - either "aws_default" (if
defined) or default boto3 mechanism -> then it will work as intended for the
user when they are running it (and it's a good example on how it should be done
- you should never set aws_conn_id = None deliberately in examples, so having
None there is not a good example.
My guess is that @ferruzzi did the None thing to avoid some other failures
or copied the behaviour from unit tests - but yeah. I would love to get
confirmation if all my assumptions were correct :)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
