potiuk commented on code in PR #46256:
URL: https://github.com/apache/airflow/pull/46256#discussion_r1934835025
##########
providers/standard/tests/provider_tests/standard/operators/test_generic_transfer.py:
##########
@@ -65,7 +65,7 @@ def teardown_method(self):
],
)
def test_mysql_to_mysql(self, client):
- from providers.tests.mysql.hooks.test_mysql import MySqlContext
+ from providers.mysql.tests.provider_tests.mysql.hooks.test_mysql
import MySqlContext
Review Comment:
I think proper fix will be copy&paste the MySQL context here. We are not
supposed to import test code between providers - their test code should be
rather independent.
We could potentially move the context to `tests_common` - because this is
where providers import common code from, but I think in this case. just copying
the context manager here will be a better solution - both MySQL tests and
Generic tests here are testing MySQL Hooks in similar way, but keeping DRY in
tests is not really a goal, tests are generally better if they are "standalone"
- even if some code is copied.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
