amoghrajesh commented on code in PR #46256:
URL: https://github.com/apache/airflow/pull/46256#discussion_r1934932127
##########
providers/standard/tests/provider_tests/standard/operators/test_generic_transfer.py:
##########
@@ -65,7 +65,7 @@ def teardown_method(self):
],
)
def test_mysql_to_mysql(self, client):
- from providers.tests.mysql.hooks.test_mysql import MySqlContext
+ from providers.mysql.tests.provider_tests.mysql.hooks.test_mysql
import MySqlContext
Review Comment:
```
class MySqlContext:
def __init__(self, client):
self.client = client
self.connection =
MySqlHook.get_connection(MySqlHook.default_conn_name)
self.init_client = self.connection.extra_dejson.get("client",
"mysqlclient")
def __enter__(self):
self.connection.set_extra(f'{{"client": "{self.client}"}}')
def __exit__(self, exc_type, exc_val, exc_tb):
self.connection.set_extra(f'{{"client": "{self.init_client}"}}')
```
This however has a `MySqlHook`. And even if i move that to `tests_common`,
it will still need importing it correct?
Even prior to my change, we imported the `MysqlHook`, just from different
path @potiuk
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
