potiuk commented on code in PR #46256:
URL: https://github.com/apache/airflow/pull/46256#discussion_r1934948654
##########
providers/standard/tests/provider_tests/standard/operators/test_generic_transfer.py:
##########
@@ -65,7 +65,7 @@ def teardown_method(self):
],
)
def test_mysql_to_mysql(self, client):
- from providers.tests.mysql.hooks.test_mysql import MySqlContext
+ from providers.mysql.tests.provider_tests.mysql.hooks.test_mysql
import MySqlContext
Review Comment:
I am not sure. Tests_common - should contain only "provider-agnostic code"
i.e. something that does not belong to any provider. By Adding MySQL there, we
make common code (which should be used by the provider tests - i.e. be
dependnecy of the provider tests) into something that is USING mysql provider.
So if mysql provider uses "tests_common" and "test_commmon" use mysql provider,
this is "almost a cycle" it only works because provider does not use tests code
- it's used by the test code..
I think I prefere copying the contextmanager in both places.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
