uranusjr commented on code in PR #46512:
URL: https://github.com/apache/airflow/pull/46512#discussion_r1948419526
##########
airflow/timetables/base.py:
##########
@@ -281,8 +282,17 @@ def generate_run_id(
self,
*,
run_type: DagRunType,
- logical_date: DateTime,
+ logical_date: DateTime | None,
data_interval: DataInterval | None,
+ run_after: DateTime = timezone.coerce_datetime(timezone.utcnow()),
Review Comment:
Let’s not change this signature now. For cases with None logical_date, let’s
just do
```python
logical_date=logical_date or run_after
```
to keep things work.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
